[Marble-devel] Review Request: OpenDesktop Plugin was migrated to the usage of MapInfoDialog

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108130/#review24599
-----------------------------------------------------------



src/plugins/render/opendesktop/OpenDesktopItem.h
<http://git.reviewboard.kde.org/r/108130/#comment18864>

    Please don't include module names - helps us with Qt5 porting


- Torsten Rahn


On Jan. 3, 2013, 4:30 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108130/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 4:30 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> OpenDesktop Plugin was migrated to the usage of MapInfoDialog according to the GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8149207
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/opendesktop/OpenDesktopItem.h 400b120 
>   src/plugins/render/opendesktop/OpenDesktopItem.cpp 1eab607 
>   src/plugins/render/opendesktop/OpenDesktopModel.h 06f8941 
>   src/plugins/render/opendesktop/OpenDesktopModel.cpp d33bbd4 
>   src/plugins/render/opendesktop/OpenDesktopPlugin.h d50f109 
>   src/plugins/render/opendesktop/OpenDesktopPlugin.cpp 884cc0a 
> 
> Diff: http://git.reviewboard.kde.org/r/108130/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Screenshots
> -----------
> 
> Current View 2
>   http://git.reviewboard.kde.org/r/108130/s/963/
> Current View 1
>   http://git.reviewboard.kde.org/r/108130/s/964/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130103/5df538fe/attachment.html>