[Marble-devel] Review Request: Nations were migrated to the usage of MapInfoDialog

Dennis Nienhüser earthwings at gentoo.org
Thu Jan 3 14:47:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108111/#review24572
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Jan. 3, 2013, 1:12 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108111/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2013, 1:12 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.
> 
> 
> Description
> -------
> 
> Nations were migrated to the usage of MapInfoDialog according to the GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8167207
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleWidgetPopupMenu.h 95c7839 
>   src/lib/MarbleWidgetPopupMenu.cpp 49fb861 
>   src/lib/libmarble.qrc 5d4d32c 
>   src/lib/webpopup/nation.html PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108111/diff/
> 
> 
> Testing
> -------
> 
> Everything is OK.
> 
> 
> Screenshots
> -----------
> 
> Current View 1
>   http://git.reviewboard.kde.org/r/108111/s/959/
> Current View 2
>   http://git.reviewboard.kde.org/r/108111/s/960/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130103/1328e48f/attachment.html>


More information about the Marble-devel mailing list