[Marble-devel] Review Request: Support relative icon paths in kml icon styles

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108039/#review24359
-----------------------------------------------------------

Ship it!


Looks great!

- Thibaut Gridel


On Dec. 30, 2012, 10:19 p.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108039/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2012, 10:19 p.m.)
> 
> 
> Review request for Marble and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> Resolves relative (local) paths relative to the kml url base path as said in https://developers.google.com/kml/documentation/kmzarchives?hl=de#externalrefs
> 
> Fixes loading of icons in icon styles when they are defined as relative local path names, e.g. <IconStyle><Icon><href>myicon.png</href></Icon></IconStyle> and myicon.png next to the .kml file containing such definition.
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/data/GeoDataDocument.cpp 2bd7f2a 
>   src/lib/geodata/data/GeoDataFeature.h 6979370 
>   src/lib/geodata/data/GeoDataFeature.cpp 0bf2337 
>   src/lib/geodata/data/GeoDataIconStyle.cpp b221821 
>   src/lib/geodata/data/GeoDataObject.h 33267a9 
>   src/lib/geodata/data/GeoDataObject.cpp 30e09af 
>   src/lib/geodata/data/GeoDataOverlay.cpp eef24f6 
>   src/lib/geodata/data/GeoDataStyle.cpp 01c4a24 
>   tests/TestGeoData.cpp 815e726 
> 
> Diff: http://git.reviewboard.kde.org/r/108039/diff/
> 
> 
> Testing
> -------
> 
> Rabet.kml and Overlay.kml from examples/kml/. Note that Rabet.kml needs to be modified to have the ylw-pushpin.png downloaded next to the .kml and the URL transformed to a local file (<href>ylw-pushpin.png</href>)
> 
> 
> Thanks,
> 
> Dennis Nienhüser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130101/bf8cd01a/attachment.html>