[Marble-devel] Review Request 108388: KML SUPPORT FOR GX:TIMESPAN AND GX:TIMESTAMP

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108388/#review27532
-----------------------------------------------------------


Just tried the patch. The tests are compiling now, but both fail with kml parser errors. To see that, go to the build folder and run
tests/TestGxTimeStamp
tests/TestGxTimeSpan

The parse error is because of a missing whitespace in "xmlns:gx=..." (should be " xmlns:gx=..."). When fixing that, there appear more errors though.


- Dennis Nienhüser


On Feb. 12, 2013, 5:29 p.m., Mayank Madan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108388/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 5:29 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> KML SUPPORT FOR GX:TIMESPAN AND GX:TIMESTAMP
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/handlers/kml/KmlGxTimeSpanTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlGxTimeSpanTagHandler.cpp PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlGxTimeStampTagHandler.h PRE-CREATION 
>   src/lib/geodata/handlers/kml/KmlGxTimeStampTagHandler.cpp PRE-CREATION 
>   tests/CMakeLists.txt cd16f98 
>   tests/TestGxTimeSpan.cpp PRE-CREATION 
>   tests/TestGxTimeStamp.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mayank Madan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130215/9f8d09f9/attachment.html>