[Marble-devel] Review Request 114743: Venus added into the Stars plugin

[Torsten Rahn]

> On Dec. 30, 2013, 9 p.m., Torsten Rahn wrote:
> > src/plugins/render/stars/StarsPlugin.cpp, line 1255
> > <https://git.reviewboard.kde.org/r/114743/diff/1/?file=228131#file228131line1255>
> >
> >     Couldn't this be
> >     
> >     m_viewSolarSystemLabel = changed;

Nevermind. The line above is correct.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114743/#review46459
-----------------------------------------------------------


On Dec. 30, 2013, 8:34 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114743/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 8:34 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Acc. to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5787756261277696), Venus added.
> 
> * bitmaps/stars/star_0_white.png is used for texture
> * displayed it at the right position using the pixmap above
> * allow for enabling and disabling the planet inside the settings dialog
> * a label for Venus
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/stars/StarsConfigWidget.ui 5beee0d 
>   src/plugins/render/stars/StarsPlugin.h 8e041da 
>   src/plugins/render/stars/StarsPlugin.cpp 544a6dc 
> 
> Diff: https://git.reviewboard.kde.org/r/114743/diff/
> 
> 
> Testing
> -------
> 
> Manual, unit-tests
> 
> 
> File Attachments
> ----------------
> 
> Venus, Sun, Moon
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/ace6a386-a42a-4a87-ae97-ba696fa547fb__Screen_Shot_2013-12-30_at_10.09.54_PM.png
> Dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/04e1f114-0c8f-4ece-a3a5-de9461c3e9e8__Screen_Shot_2013-12-30_at_10.21.07_PM.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131230/60346d86/attachment.html>