[Marble-devel] Review Request 114740: Add KML support for displaying ListStyle::backgroundColor inside the file view

Torsten Rahn tackat at kde.org
Mon Dec 30 17:02:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114740/#review46450
-----------------------------------------------------------



src/lib/marble/geodata/handlers/kml/KmlStyleUrlTagHandler.cpp
<https://git.reviewboard.kde.org/r/114740/#comment33119>

    ++i - we prefer preincrement where possible.


- Torsten Rahn


On Dec. 30, 2013, 4:23 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114740/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 4:23 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This is a GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5832784698408960
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/handlers/kml/KmlStyleUrlTagHandler.cpp 38fee3e 
>   src/lib/marble/GeoDataTreeModel.cpp 36cb5a5 
> 
> Diff: https://git.reviewboard.kde.org/r/114740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131230/3398ef0d/attachment.html>


More information about the Marble-devel mailing list