[Marble-devel] Review Request 114732: StarsPlugin user interface refactoring

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114732/#review46427
-----------------------------------------------------------


Reopening the review request because of multiple issues :-(



src/plugins/render/stars/StarsPlugin.h
<https://git.reviewboard.kde.org/r/114732/#comment33104>

    A read-only, uninitialized variable!



src/plugins/render/stars/StarsPlugin.h
<https://git.reviewboard.kde.org/r/114732/#comment33105>

    None of these variables is initialized in the constructor, leading to random segfaults when showing the context menu (accessing a broken pointer) for the first time or when shutting down marble (deleting a broken pointer). Please fix!
    
    


- Dennis Nienhüser


On Dec. 29, 2013, 9:40 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114732/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2013, 9:40 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (https://google-melange.appspot.com/gci/task/view/google/gci2013/5811309861928960):
> 
> Refactoring of the StarsPlugin is accomplished. Memory leaks fixed, UI layout (menu entries) improved.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/stars/StarsPlugin.h 662ab1a 
>   src/plugins/render/stars/StarsPlugin.cpp 9a6fd4d 
> 
> Diff: https://git.reviewboard.kde.org/r/114732/diff/
> 
> 
> Testing
> -------
> 
> All possible behaviours tested, unit-tests.
> 
> 
> File Attachments
> ----------------
> 
> Context menu
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/f4880fe8-21d2-4270-8593-bf40ad7b8b53__Screen_Shot_2013-12-29_at_11.22.43_PM.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131230/e67f5e4f/attachment.html>