[Marble-devel] Review Request 114729: Improve support for text rendering of the BalloonStyle

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114729/#review46401
-----------------------------------------------------------



src/lib/marble/geodata/data/GeoDataFeature.cpp
<https://git.reviewboard.kde.org/r/114729/#comment33083>

    The KML snippet tag has a maxLines attribute. Ideally we'd support it as well and introduce a GeoDataSnippet class (with a maxLines property) instead of using QString here.
    



src/lib/marble/geodata/data/GeoDataFeature.cpp
<https://git.reviewboard.kde.org/r/114729/#comment33082>

    I wonder if this breaks .cache file loading. Does the Atlas map theme still show cities?



src/lib/marble/layers/PopupLayer.cpp
<https://git.reviewboard.kde.org/r/114729/#comment33081>

    This method seems to mix up with setContent() now. Why not merge setContent(QString) and setStyle() into setPlacemark(GeoDataPlacemark)?


- Dennis Nienhüser


On Dec. 29, 2013, 6:45 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114729/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2013, 6:45 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This is a GCI task.
> 
> Added handling of $[*] and the displayMode tag.
> 
> Screenshot: http://oi39.tinypic.com/2mrsge8.jpg
> KML used in screenie: http://ur1.ca/ga2l0
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleWidgetPopupMenu.cpp d6fb4a6 
>   src/lib/marble/geodata/data/GeoDataFeature.h b54e3e5 
>   src/lib/marble/geodata/data/GeoDataFeature.cpp ba7d952 
>   src/lib/marble/geodata/data/GeoDataFeature_p.h 92de8a1 
>   src/lib/marble/layers/PopupLayer.h 06c73c7 
>   src/lib/marble/layers/PopupLayer.cpp ff554d1 
> 
> Diff: https://git.reviewboard.kde.org/r/114729/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Handler for <Snippet>
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/ce1c0085-1a82-4839-b476-575a99018c1c__KmlSnippetTagHandler.cpp
> Handler for Snippet tag (header)
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/b776a288-8a50-4a2e-917c-990662420e98__KmlSnippetTagHandler.h
> screenie
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/b71132cb-f7b5-4c83-804c-82e0256fa00b__snapshot2.png
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131229/bdfc4150/attachment.html>