[Marble-devel] Review Request 114728: Moon/Sun rendering improvements

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Sun Dec 29 18:34:18 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 29, 2013, 6:34 p.m.)


This change has been marked as submitted.

Review request for Marble and Torsten Rahn.

Repository: marble


According to Google Code-In 2013 task (https://google-melange.appspot.com/gci/task/view/google/gci2013/5799636140818432):

* Moon pixmap updated
* Sun  pixmap updated
* The size of the sun is rendered the same way as we render the moon right now including diameter calculation and magnifying mode
* The backdrop-glow is rendered separately before rendering the sun
* The moon is rendered after the sun has been rendered (so that it can eclipse the sun during eclipses)
* Labels added
* The functionality provided is synced with the settings dialog.


  data/CMakeLists.txt 9ac9620 
  data/svg/glow.png PRE-CREATION 
  data/svg/sun.png 810ebed 
  src/lib/marble/MarbleWidgetPopupMenu.cpp d6fb4a6 
  src/lib/marble/layers/PopupLayer.h 06c73c7 
  src/lib/marble/layers/PopupLayer.cpp ff554d1 
  src/plugins/render/stars/StarsPlugin.cpp aa3eaac 

Diff: https://git.reviewboard.kde.org/r/114728/diff/


Screens, tested, unit-tests.


Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131229/a5cf9574/attachment-0001.html>

More information about the Marble-devel mailing list