[Marble-devel] Review Request 114728: Moon/Sun rendering improvements

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114728/#review46397
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Dec. 29, 2013, 5:28 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114728/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2013, 5:28 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (https://google-melange.appspot.com/gci/task/view/google/gci2013/5799636140818432):
> 
> * Moon pixmap updated
> * Sun  pixmap updated
> * The size of the sun is rendered the same way as we render the moon right now including diameter calculation and magnifying mode
> * The backdrop-glow is rendered separately before rendering the sun
> * The moon is rendered after the sun has been rendered (so that it can eclipse the sun during eclipses)
> * Labels added
> * The functionality provided is synced with the settings dialog.
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 9ac9620 
>   data/svg/glow.png PRE-CREATION 
>   data/svg/sun.png 810ebed 
>   src/lib/marble/MarbleWidgetPopupMenu.cpp d6fb4a6 
>   src/lib/marble/layers/PopupLayer.h 06c73c7 
>   src/lib/marble/layers/PopupLayer.cpp ff554d1 
>   src/plugins/render/stars/StarsPlugin.cpp aa3eaac 
> 
> Diff: https://git.reviewboard.kde.org/r/114728/diff/
> 
> 
> Testing
> -------
> 
> Screens, tested, unit-tests.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131229/bac23cdc/attachment.html>