[Marble-devel] Review Request 114710: [GCI] Refactoring the settings dialog of the stars plugin.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114710/#review46307
-----------------------------------------------------------



src/plugins/render/stars/StarsPlugin.cpp
<https://git.reviewboard.kde.org/r/114710/#comment33038>

    Could we get rid of the magic number and add a comment what is done here?


- Torsten Rahn


On Dec. 28, 2013, 6:01 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114710/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2013, 6:01 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Refactoring the settings dialog of the stars plugin.
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5906293063680000
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/stars/StarsConfigWidget.ui ae51296 
>   src/plugins/render/stars/StarsPlugin.h 72c30bc 
>   src/plugins/render/stars/StarsPlugin.cpp 8ad067b 
> 
> Diff: https://git.reviewboard.kde.org/r/114710/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131228/9910bb12/attachment.html>