[Marble-devel] Review Request 114680: Showing the Moon in the Stars plug-in

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114680/#review46177
-----------------------------------------------------------



src/plugins/render/stars/StarsPlugin.cpp
<https://git.reviewboard.kde.org/r/114680/#comment32977>

    This should only get rendered for Earth



src/plugins/render/stars/StarsPlugin.cpp
<https://git.reviewboard.kde.org/r/114680/#comment32978>

    We need to "cache" this in the future.



src/plugins/render/stars/StarsPlugin.cpp
<https://git.reviewboard.kde.org/r/114680/#comment32979>

    I will provide a moon pixmap for a future task that will add the phases of the moon.


- Torsten Rahn


On Dec. 27, 2013, 1:27 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114680/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 1:27 a.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (https://google-melange.appspot.com/gci/task/view/google/gci2013/5246191822438400):
> 
> StarsPlugin is showing the Moon (the same pixmap sun has), settings adjusted
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/stars/CMakeLists.txt 94e0e74 
>   src/plugins/render/stars/StarsConfigWidget.ui a8c434d 
>   src/plugins/render/stars/StarsPlugin.h 04bd24a 
>   src/plugins/render/stars/StarsPlugin.cpp e7271fc 
> 
> Diff: https://git.reviewboard.kde.org/r/114680/diff/
> 
> 
> Testing
> -------
> 
> Tested, confirmed
> 
> 
> File Attachments
> ----------------
> 
> Moon there
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/12/27/75952cb0-fb54-44ad-ae59-5752306b3d59__Screen_Shot_2013-12-27_at_3.20.39_AM.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131227/1779c231/attachment.html>