[Marble-devel] Review Request 114353: Playback of KML Tours

[Dennis Nienhüser]

> On Dec. 16, 2013, 8:39 p.m., Bernhard Beschow wrote:
> > src/lib/marble/TourWidget.cpp, line 73
> > <https://git.reviewboard.kde.org/r/114353/diff/6/?file=225579#file225579line73>
> >
> >     Please remove when m_playback is a value.
> 
> Illya Kovalevskyy wrote:
>     Why should I? Afaik, GeoDataTour is created dynamically and loaded with setTour(), so having this as pointer makes sense, doesn't it?

I think Bernhard's point is that storing the pointer is not needed: Instead of deleting m_playback and storing m_tour for lazy TourPlayback creation later on you can simply pass a newly loaded/created tour directly to m_playback. This means that you need to reset its internal state however when the tour changes.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114353/#review45810
-----------------------------------------------------------


On Dec. 16, 2013, 6:24 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114353/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:24 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5813452580847616):
> 
> KML tours are played now by TourPlayback class and integrated into TourWidget. It works well and no bugs detected
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/libmarble.qrc 064e1b3 
>   src/lib/marble/TourWidget.cpp d595418 
>   src/lib/marble/TourWidget.ui 874ecfb 
>   src/lib/marble/TourWidget.h c18c849 
>   src/lib/marble/TourPlayback.cpp PRE-CREATION 
>   src/lib/marble/TourPlayback.h PRE-CREATION 
>   src/lib/marble/CMakeLists.txt fd5bd3a 
>   src/apps/marble-ui/icons/16x16/media-record.png PRE-CREATION 
>   src/apps/marble-ui/icons/16x16/media-playback-stop.png PRE-CREATION 
>   src/apps/marble-ui/icons/16x16/media-playback-start.png PRE-CREATION 
>   src/apps/marble-ui/icons/16x16/media-playback-pause.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114353/diff/
> 
> 
> Testing
> -------
> 
> Official KML examples, unit-tests
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131222/54b47938/attachment.html>