[Marble-devel] Review Request 114530: Fixes build with Qt5

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114530/#review45933
-----------------------------------------------------------

Ship it!


Please push with the additional source code comments. I'd like to have the build fixed, but avoid regressions.

We have a Qt5 jenkins build now btw., see http://build.kde.org/job/marble_master_qt5/


src/apps/marble-mobile/MobileMainWindow.cpp
<http://git.reviewboard.kde.org/r/114530/#comment32789>

    Can you add a FIXME comment asking why tr() is not used here? There should be a comment in the code at least explaining it.
    



src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp
<http://git.reviewboard.kde.org/r/114530/#comment32787>

    This seems wrong in the original code as it overwrites the user configured plan setting (see above). Can you remove that line in a separate commit?
    



src/plugins/runner/mapquest/MapQuestRunner.cpp
<http://git.reviewboard.kde.org/r/114530/#comment32788>

    Can you add a FIXME comment here to have someone verify this actually works? I'm wondering about keys with special characters like %.
    
    


- Dennis Nienhüser


On Dec. 19, 2013, 3:05 p.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114530/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 3:05 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch fixes Marble buidl with Qt5. We were using a lot of depreceated stuff on Qt.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-mobile/MobileMainWindow.cpp 2eadff5 
>   src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp cba3870 
>   src/plugins/runner/mapquest/MapQuestRunner.cpp 4506eec 
> 
> Diff: http://git.reviewboard.kde.org/r/114530/diff/
> 
> 
> Testing
> -------
> 
> Compiles under Qt4 and 5.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131219/6da957f7/attachment.html>