[Marble-devel] Review Request 114530: Fixes build with Qt5

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114530/#review45918
-----------------------------------------------------------



src/apps/marble-mobile/MobileMainWindow.cpp
<http://git.reviewboard.kde.org/r/114530/#comment32754>

    I don't see why QApplication::translate is used here originally. Bernhard, can you comment on this? I'd rather use plain ol' tr() like in the rest of the file.
    



src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp
<http://git.reviewboard.kde.org/r/114530/#comment32755>

    There's quite a lot of duplication here. Can you use a QMap<QString,QString> commonly to store the key/value pairs and iterate over it later on? Then we only have one place with an #ifdef 
    
    


- Dennis Nienhüser


On Dec. 18, 2013, 7:39 p.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114530/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2013, 7:39 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch fixes Marble buidl with Qt5. We were using a lot of depreceated stuff on Qt.
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/mapquest/MapQuestRunner.cpp 4506eec 
>   src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp cba3870 
>   src/apps/marble-mobile/MobileMainWindow.cpp 2eadff5 
> 
> Diff: http://git.reviewboard.kde.org/r/114530/diff/
> 
> 
> Testing
> -------
> 
> Compiles under Qt4 and 5.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131218/2ac8b7eb/attachment.html>