[Marble-devel] Review Request 114529: Do not #define pi on marble sources, use M_PI instead.

Tomaz Canabrava tcanabrava at kde.org
Wed Dec 18 17:35:49 UTC 2013

This is an automatically generated e-mail. To reply, visit:

Review request for Marble.

Repository: marble


This patch changes #define pi to M_PI - even knowing that it's not the standard, it's what most people should look like when looking for 'pi', and that define actually broke Marble's compilation on Qt5 because a QVariant used a variable named 'pi' internally that didn't had a thing to do with the math constant... ;p


  src/plugins/render/satellites/sgp4/sgp4ext.cpp 6eb1ac2 
  src/plugins/render/satellites/sgp4/sgp4io.cpp 84f4aa2 
  src/plugins/render/satellites/sgp4/sgp4unit.h 5d71430 
  src/plugins/render/satellites/sgp4/sgp4unit.cpp 1d34c00 

Diff: http://git.reviewboard.kde.org/r/114529/diff/


None - there are other errors that I need to fix for Qt5 before I actually test it. but since it was just a definition change, I doub't it created any regressions.


Tomaz  Canabrava

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131218/1dcc7673/attachment.html>

More information about the Marble-devel mailing list