[Marble-devel] Review Request 114268: ESA SoCIS 2013 - Use the astro library in satellites plugins

[René Küttner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114268/#review45851
-----------------------------------------------------------


The astro library is not linked to the satellites plugin with this patch.
You may have to additionally specify target_link_libraries(..) the the end of CMakeLists.txt.

I think we can ship this as soon as the above issue has been fixed.

- René Küttner


On Dec. 12, 2013, 2:51 a.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114268/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 2:51 a.m.)
> 
> 
> Review request for Marble, Torsten Rahn and René Küttner.
> 
> 
> Bugs: feature
>     http://bugs.kde.org/show_bug.cgi?id=feature
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> It was removed internal astro source code. The source code has been replaced by a reference to the astro library, which is located in the marble central space. 
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/satellites/CMakeLists.txt 03650a4 
>   src/plugins/render/satellites/SatellitesMSCItem.h f1fff67 
>   src/plugins/render/satellites/SatellitesModel.cpp 5d73653 
>   src/plugins/render/satellites/mex/README 2903c53 
>   src/plugins/render/satellites/mex/astrolib.h 8a878e8 
>   src/plugins/render/satellites/mex/astrolib.cpp a1d5cbf 
>   src/plugins/render/satellites/mex/attlib.h 7e209cf 
>   src/plugins/render/satellites/mex/attlib.cpp 0264bd7 
>   src/plugins/render/satellites/mex/planetarySats.h 0ed34c7 
>   src/plugins/render/satellites/mex/planetarySats.cpp ec31a20 
> 
> Diff: http://git.reviewboard.kde.org/r/114268/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131217/bb3a7da0/attachment.html>