[Marble-devel] Review Request 114474: Show journey length and duration for locally cached routes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114474/#review45736
-----------------------------------------------------------


Can you also change RouteItemDelegate::text and activate the commented part so that the duration and length are shown in the remote routes dialog?


src/lib/marble/cloudsync/OwncloudSyncBackend.cpp
<http://git.reviewboard.kde.org/r/114474/#comment32671>

    Shouldn't this work on the second placemark in the first folder of the document?
    
    there should be a safety check for doc != 0 and doc->size() > 0



src/lib/marble/cloudsync/OwncloudSyncBackend.cpp
<http://git.reviewboard.kde.org/r/114474/#comment32672>

    Shouldn't this work on the second placemark in the first folder of the document?
    
    there should be a safety check for doc != 0 and doc->size() > 0



src/lib/marble/cloudsync/OwncloudSyncBackend.cpp
<http://git.reviewboard.kde.org/r/114474/#comment32669>

    Crashes here when the list of routes is empty. doc->size() should be doc->folderList().size()


- Dennis Nienhüser


On Dec. 15, 2013, 2:36 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114474/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 2:36 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5802823878967296):
> 
> Marble can store routes and bookmarks in an owncloud server. The upload API needs information about the length and duration of routes that are uploaded. The same information should be extracted for routes which are only available on the local system.
> 
> * QTime duration(const GeoDataDocument* document) const
> * double  length(const GeoDataDocument* document) const
> * QString   name(const GeoDataDocument* document) const
> * RouteSyncManager::cachedRouteList() refactored
> * OwncloudSyncBackend::uploadRoute() updated
> * OwncloudSyncBackend::routeName() removed
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/cloudsync/OwncloudSyncBackend.h 5038f69 
>   src/lib/marble/cloudsync/OwncloudSyncBackend.cpp 889522e 
>   src/lib/marble/cloudsync/RouteSyncManager.cpp c873ff1 
> 
> Diff: http://git.reviewboard.kde.org/r/114474/diff/
> 
> 
> Testing
> -------
> 
> Unit tests & manual testing on runtime
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131215/3e1f95da/attachment.html>