[Marble-devel] Review Request 114353: Playback of KML Tours

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114353/#review45677
-----------------------------------------------------------



src/lib/marble/TourPlayback.h
<http://git.reviewboard.kde.org/r/114353/#comment32641>

    s/slots/Q_SLOTS/



src/lib/marble/TourPlayback.h
<http://git.reviewboard.kde.org/r/114353/#comment32640>

    s/signals/Q_SIGNALS/



src/lib/marble/TourPlayback.cpp
<http://git.reviewboard.kde.org/r/114353/#comment32635>

    Please make read-only, i.e. const GeoDataTour.



src/lib/marble/TourPlayback.cpp
<http://git.reviewboard.kde.org/r/114353/#comment32636>

    " slots" not needed



src/lib/marble/TourPlayback.cpp
<http://git.reviewboard.kde.org/r/114353/#comment32633>

    If you emit a signal here, you could remove the m_widget attribute.



src/lib/marble/TourPlayback.cpp
<http://git.reviewboard.kde.org/r/114353/#comment32634>

    Dito



src/lib/marble/TourPlayback_p.h
<http://git.reviewboard.kde.org/r/114353/#comment32637>

    This file seems not to be used. Please remove.



src/lib/marble/TourWidget.h
<http://git.reviewboard.kde.org/r/114353/#comment32639>

    s/slots/Q_SLOTS/



src/lib/marble/TourWidget.cpp
<http://git.reviewboard.kde.org/r/114353/#comment32638>

    Perhaps it's simpler to turn m_playback into a value (rather than a pointer), so you always know that m_playback is around.
    
    Since in this case you won't pass a GeoDataTour object to TourPlayback upon construction, you'd need to add e.g. TourPlayback::setTour() and refactor TourPlayback internally to deal correctly with null tours. Furthermore, this allows you to even spare the m_tour attribute in this class.


- Bernhard Beschow


On Dec. 13, 2013, 11:26 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114353/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 11:26 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5813452580847616):
> 
> KML tours are played now by TourPlayback class and integrated into TourWidget. It works well and no bugs detected
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-ui/icons/16x16/media-playback-pause.png PRE-CREATION 
>   src/apps/marble-ui/icons/16x16/media-playback-start.png PRE-CREATION 
>   src/apps/marble-ui/icons/16x16/media-playback-stop.png PRE-CREATION 
>   src/apps/marble-ui/icons/16x16/media-record.png PRE-CREATION 
>   src/lib/marble/CMakeLists.txt fd5bd3a 
>   src/lib/marble/TourPlayback.h PRE-CREATION 
>   src/lib/marble/TourPlayback.cpp PRE-CREATION 
>   src/lib/marble/TourPlayback_p.h PRE-CREATION 
>   src/lib/marble/TourWidget.h c18c849 
>   src/lib/marble/TourWidget.cpp d595418 
>   src/lib/marble/TourWidget.ui 874ecfb 
>   src/lib/marble/libmarble.qrc 064e1b3 
> 
> Diff: http://git.reviewboard.kde.org/r/114353/diff/
> 
> 
> Testing
> -------
> 
> Official KML examples, unit-tests
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131214/5b8e9de3/attachment.html>