[Marble-devel] Review Request 114438: Added support for reading and writing gx:altitudeMode KML tags

[Sanjiban Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114438/
-----------------------------------------------------------

Review request for Marble.


Bugs: 320009
    http://bugs.kde.org/show_bug.cgi?id=320009


Repository: marble


Description
-------

- Extended the AltitudeMode enum in src/lib/MarbleGlobal.h by the two additional values
- Added a KmlGxAltitudeModeTagHandler that behaves like the existing KmlAltitudeModeTagHandler, but listens to the gx: namespace and parses the two additional values also
- Added a writeAltitudeMode(...) function in KmlGroundOverlayWriter which can both write <altitudeMode> and <gx:altitudeMode> and have it switch between both based on the enum value to write
- Changed KmlCameraTagWriter.cpp, KmlGroundOverlayWriter.cpp, KmlLatLonAltBoxWriter.cpp and KmlModelTagWriter.cpp to use the new writeAltitudeMode(...) function instead of writing altitudeMode manually
- Add a test .kml file to tests/data/ which has various combinations of altitudeMode inside and outside the gx namespace with various values.


Diffs
-----

  src/lib/marble/MarbleGlobal.h b130c0c 
  src/lib/marble/geodata/CMakeLists.txt 1918472 
  src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.h PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.cpp PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlCameraTagWriter.cpp a91f2cc 
  src/lib/marble/geodata/writers/kml/KmlGroundOverlayWriter.h ebcf44e 
  src/lib/marble/geodata/writers/kml/KmlGroundOverlayWriter.cpp 3fa0c0e 
  src/lib/marble/geodata/writers/kml/KmlLatLonAltBoxWriter.cpp c955c91 
  src/lib/marble/geodata/writers/kml/KmlModelTagWriter.cpp 14186f9 
  tests/TestGeoDataWriter.cpp be2e5f4 
  tests/data/AltitudeMode.kml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/114438/diff/


Testing
-------


Thanks,

Sanjiban Bairagya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131213/57a0ac2e/attachment-0001.html>