[Marble-devel] Review Request 114372: [GCI] Added support for playback of soundCue elements in KML Tour.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114372/#review45447
-----------------------------------------------------------


Looks good. Ideally we would keep Phonon an optional dependeny though like in the routing plugin: only link against it in CMakeLists.txt if it is found, guard phonon objects and includes with #ifdef in the code.
The reason for that is that Phonon is not treated as a core part of Qt unfortunately, so people might have Qt installed but not Phonon.

- Dennis Nienhüser


On Dec. 9, 2013, 5:53 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114372/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 5:53 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added support for playback of soundCue elements in KML Tour.
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5858606377336832
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt fd5bd3a 
>   src/lib/marble/TourPlayback.h PRE-CREATION 
>   src/lib/marble/TourPlayback.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131210/12ba58e4/attachment.html>