[Marble-devel] Review Request 114353: Playback of KML Tours

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114353/#review45356
-----------------------------------------------------------



src/lib/marble/TourPlayback.h
<http://git.reviewboard.kde.org/r/114353/#comment32374>

    can we call it finished()?



src/lib/marble/TourPlayback.cpp
<http://git.reviewboard.kde.org/r/114353/#comment32376>

    should be a dynamic_cast



src/lib/marble/TourPlayback.cpp
<http://git.reviewboard.kde.org/r/114353/#comment32375>

    should check that m_cues is not empty
    Also m_cues needs to be cleared when playback finishes


- Dennis Nienhüser


On Dec. 8, 2013, 5:32 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114353/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2013, 5:32 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5813452580847616):
> 
> KML tours are played now by TourPlayback class and integrated into TourWidget. It works well and no bugs detected
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt fd5bd3a 
>   src/lib/marble/TourPlayback.h PRE-CREATION 
>   src/lib/marble/TourPlayback.cpp PRE-CREATION 
>   src/lib/marble/TourPlayback_p.h PRE-CREATION 
>   src/lib/marble/TourWidget.h 3db12c8 
>   src/lib/marble/TourWidget.cpp eaec55a 
>   src/lib/marble/TourWidget.ui a27d129 
> 
> Diff: http://git.reviewboard.kde.org/r/114353/diff/
> 
> 
> Testing
> -------
> 
> Official KML examples, unit-tests
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131208/2a4e6b12/attachment.html>