[Marble-devel] Review Request 114351: [GCI] Added support for basic KML tour file management.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114351/#review45355
-----------------------------------------------------------


Looks good. I added icons document-new, document-save and document-save-as to git master, can you set them for the buttons, please?


src/lib/marble/TourWidget.cpp
<http://git.reviewboard.kde.org/r/114351/#comment32371>

    const QString &filename



src/lib/marble/TourWidget.cpp
<http://git.reviewboard.kde.org/r/114351/#comment32373>

    From the users perspective this behaves slightly odd when you have unsaved changes: First you get a file open dialog, afterwards a dialog asking you if you really want to open that file and discard all changes



src/lib/marble/TourWidget.cpp
<http://git.reviewboard.kde.org/r/114351/#comment32372>

    possibly also
    m_tourUi.m_actionSaveTour->setEnabled( true );
    to be consistent with what happens when you add a flyto


- Dennis Nienhüser


On Dec. 8, 2013, 3:56 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114351/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2013, 3:56 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added support for basic KML tour file management.
> GCI: http://www.google-melange.com/gci/task/view/google/gci2013/5772200225275904
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.h 3db12c8 
>   src/lib/marble/TourWidget.cpp eaec55a 
>   src/lib/marble/TourWidget.ui a27d129 
> 
> Diff: http://git.reviewboard.kde.org/r/114351/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131208/5304b9c3/attachment-0001.html>