[Marble-devel] Review Request 114270: Give Feedback Whether Owncloud Login Credentials are Correct in Marble

[Benjamin Kaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114270/
-----------------------------------------------------------

(Updated Dec. 8, 2013, 10:59 a.m.)


Status
------

This change has been marked as submitted.


Review request for Marble and Dennis Nienhüser.


Repository: marble


Description
-------

Give Feedback Whether Owncloud Login Credentials are Correct in Marble.

This has been implemented for both the marble-qt and marble-kde applications settings. Note however that I had to add UI code to both their classes, because the UI building code was not inside the ControlView class. The logic behind the login credential checking was implemented in the correct place (OwncloudSyncBackend).

GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5900404730626048


Diffs
-----

  src/apps/marble-kde/marble_part.h ddb91ea 
  src/apps/marble-kde/marble_part.cpp 082ad5e 
  src/apps/marble-qt/QtMainWindow.cpp a713272 
  src/lib/marble/MarbleCloudSyncSettingsWidget.ui 9257dac 
  src/lib/marble/QtMarbleConfigDialog.h 95be36d 
  src/lib/marble/QtMarbleConfigDialog.cpp b8a85c0 
  src/lib/marble/cloudsync/CloudSyncManager.h 7955bc8 
  src/lib/marble/cloudsync/CloudSyncManager.cpp caa9536 
  src/lib/marble/cloudsync/OwncloudSyncBackend.h 715f60c 
  src/lib/marble/cloudsync/OwncloudSyncBackend.cpp 8af8182 

Diff: http://git.reviewboard.kde.org/r/114270/diff/


Testing
-------

Run both the `marble` (marble-kde) and `marble-qt` applications. 


Thanks,

Benjamin Kaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131208/820a94c2/attachment.html>