[Marble-devel] Review Request 114339: Support for the gx:SoundCue KML tag

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114339/
-----------------------------------------------------------

Review request for Marble and Dennis Nienhüser.


Repository: marble


Description
-------

According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5841112170233856):

Handlers/writers for gx:SoundCue (and all related new tags) are created, related tests are adjusted. Reading/writing for the gx:Playlist tag (which one is main container of gx:SoundCue is working well).


Diffs
-----

  src/lib/marble/geodata/CMakeLists.txt 9206b3f 
  src/lib/marble/geodata/data/GeoDataPlaylist.h 8b0e411 
  src/lib/marble/geodata/data/GeoDataPlaylist.cpp dc85421 
  src/lib/marble/geodata/data/GeoDataSoundCue.h PRE-CREATION 
  src/lib/marble/geodata/data/GeoDataSoundCue.cpp PRE-CREATION 
  src/lib/marble/geodata/data/GeoDataTour.h 9415c60 
  src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h 2a45419 
  src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp 6473bca 
  src/lib/marble/geodata/handlers/kml/KmlHrefTagHandler.cpp 6f9204a 
  src/lib/marble/geodata/handlers/kml/KmlSoundCueTagHandler.h PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmlSoundCueTagHandler.cpp PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmldelayedStartTagHandler.h PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmldelayedStartTagHandler.cpp PRE-CREATION 
  src/lib/marble/geodata/parser/GeoDataTypes.h b201936 
  src/lib/marble/geodata/parser/GeoDataTypes.cpp 87b1f00 
  src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.h 24e87f9 
  src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp 896650f 
  tests/TestGeoDataWriter.cpp 4d79ce0 
  tests/data/Tour.kml 3b04c83 
  tests/data/TourWait.kml 52c724e 

Diff: http://git.reviewboard.kde.org/r/114339/diff/


Testing
-------

Related unit tests


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131207/fd3f314e/attachment.html>