[Marble-devel] Review Request 114281: [GCI] Added support for the gx:Wait KML element

Dennis Nienhüser earthwings at gentoo.org
Tue Dec 3 22:40:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114281/#review45067
-----------------------------------------------------------

Ship it!


Great work!

- Dennis Nienhüser


On Dec. 3, 2013, 6:49 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114281/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 6:49 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added support for the gx:Wait KML element. GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5819304473788416
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/CMakeLists.txt 8583e3e 
>   src/lib/marble/geodata/data/GeoDataWait.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataWait.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlDurationTagHandler.cpp d4f19d8 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h 260d339 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp c4b826e 
>   src/lib/marble/geodata/handlers/kml/KmlWaitTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlWaitTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/parser/GeoDataTypes.h 356467f 
>   src/lib/marble/geodata/parser/GeoDataTypes.cpp d9f7286 
>   src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.h 6c5e310 
>   src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp 844d198 
>   tests/TestGeoDataWriter.cpp 3fd3aad 
>   tests/data/TourWait.kml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114281/diff/
> 
> 
> Testing
> -------
> 
> Tested by launching TestGeoDataWriter with simple kml file which include gx:Wait element.
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131203/fdba6525/attachment.html>


More information about the Marble-devel mailing list