[Marble-devel] Review Request 114199: Notify the user if anything goes wrong during route synchronization

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114199/#review44945
-----------------------------------------------------------



src/lib/marble/cloudsync/CloudRouteModel.cpp
<http://git.reviewboard.kde.org/r/114199/#comment32135>

    should maybe check that message is != "", and only complain via mDebug() in that case



src/lib/marble/cloudsync/CloudSyncManager.h
<http://git.reviewboard.kde.org/r/114199/#comment32136>

    const QString &



src/lib/marble/cloudsync/CloudSyncManager.h
<http://git.reviewboard.kde.org/r/114199/#comment32137>

    const QString &



src/lib/marble/cloudsync/CloudSyncManager.cpp
<http://git.reviewboard.kde.org/r/114199/#comment32138>

    const QString &



src/lib/marble/cloudsync/OwncloudSyncBackend.h
<http://git.reviewboard.kde.org/r/114199/#comment32139>

    const QString &



src/lib/marble/cloudsync/OwncloudSyncBackend.cpp
<http://git.reviewboard.kde.org/r/114199/#comment32140>

    Please move the status evaluation and error emission to its own method to avoid the code duplication in confirmRouteUploaded() and confirmRouteDeleted()


- Dennis Nienhüser


On Dec. 1, 2013, 3:26 p.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114199/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 3:26 p.m.)
> 
> 
> Review request for Marble and Eric Newberry.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Posted here on behalf of GCI student Eric Newberry. Task: https://www.google-melange.com/gci/task/view/google/gci2013/5773791242223616
> The patch adds ability to Marble's desktop version to notify the user if anything goes wrong.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-ui/ControlView.cpp 74a7ba3 
>   src/lib/marble/cloudsync/CloudRouteModel.h d5d1c1f 
>   src/lib/marble/cloudsync/CloudRouteModel.cpp e1ad467 
>   src/lib/marble/cloudsync/CloudSyncManager.h 7955bc8 
>   src/lib/marble/cloudsync/CloudSyncManager.cpp caa9536 
>   src/lib/marble/cloudsync/OwncloudSyncBackend.h 715f60c 
>   src/lib/marble/cloudsync/OwncloudSyncBackend.cpp 8af8182 
> 
> Diff: http://git.reviewboard.kde.org/r/114199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Utku Aydın
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131201/f6ffee72/attachment.html>