[Marble-devel] Review Request 114206: Add menu option (and shortcut) to show/hide all docking panels

[Daniel Lanzi]

> On Dec. 1, 2013, 7:51 a.m., Dennis Nienhüser wrote:
> > src/apps/marble-ui/ControlView.cpp, line 666
> > <http://git.reviewboard.kde.org/r/114206/diff/1/?file=221467#file221467line666>
> >
> >     The indentation looks mixed up. Please indent with four spaces, no tabs. If you are using QtCreator, just select the method and press Ctrl+I.
> >

I am using Geany. I thought that it was set to space indent. I think it got confused.


> On Dec. 1, 2013, 7:51 a.m., Dennis Nienhüser wrote:
> > src/apps/marble-ui/ControlView.h, line 114
> > <http://git.reviewboard.kde.org/r/114206/diff/1/?file=221466#file221466line114>
> >
> >     Doesn't really reflect what is happening, please rename to something like
> >     togglePanelVisibility()
> >

I took your advice on naming. I went back and forth on the name of the function.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114206/#review44917
-----------------------------------------------------------


On Dec. 1, 2013, 3:50 p.m., Daniel Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114206/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 3:50 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds a separated menu item on the Settings->Panels menu for showing and also hiding all of the panels at once. The code assigns f9 as the shortcut key. The patch is added to the ControlView module and is shared by the qt and kde versions of marble.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-ui/ControlView.h 8fc3dfb 
>   src/apps/marble-ui/ControlView.cpp 74a7ba3 
> 
> Diff: http://git.reviewboard.kde.org/r/114206/diff/
> 
> 
> Testing
> -------
> 
> Code was tested in both qt and kde versions.
> 
> 
> Thanks,
> 
> Daniel Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131201/3a9b65ee/attachment.html>