[Marble-devel] Review Request 114170: Basic implementation of movie capturing

[Torsten Rahn]

> On Dec. 1, 2013, 9:25 a.m., Dennis Nienhüser wrote:
> > src/lib/marble/MovieCapture.cpp, line 42
> > <http://git.reviewboard.kde.org/r/114170/diff/3/?file=221890#file221890line42>
> >
> >     the directory name should somehow hint that it is related to Marble. e.g. "Marble-Screencasts"

actually in case the  ffmpeg or avconv binary is found the bmps should rather get stored into a temporary directory.


> On Dec. 1, 2013, 9:25 a.m., Dennis Nienhüser wrote:
> > src/lib/marble/MovieCapture.cpp, line 29
> > <http://git.reviewboard.kde.org/r/114170/diff/3/?file=221890#file221890line29>
> >
> >     A static time driven frame rate is usually a bad guess. Either the value is too high and you'll queue up image requests, or too low and you get worse results than the system would support. A better approach is to start recording the next frame a slight amount after the current one has been processed. It's very easy to implement as well: Just call something like
> >     QTimer::singleShot( 10, this, SLOT(recordFrame()) );
> >     in recordFrame(), and use a boolean flag to stop recording.
> >

I'd be curious about the maximum framerate that can be accomplished on your machine.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114170/#review44920
-----------------------------------------------------------


On Nov. 30, 2013, 2:37 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114170/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 2:37 p.m.)
> 
> 
> Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5805119807422464):
> 
> Basic template + implementation of timer-based fps marblewidget caster. Current impl saves 1 fps to home directory in BMP format (as separate files).
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp a713272 
>   src/apps/marble-ui/icons/16x16/tool-animator.png PRE-CREATION 
>   src/apps/marble-ui/marble.qrc 5ff3a32 
>   src/lib/marble/CMakeLists.txt 8f2c6eb 
>   src/lib/marble/MovieCapture.h PRE-CREATION 
>   src/lib/marble/MovieCapture.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114170/diff/
> 
> 
> Testing
> -------
> 
> UI/UX, unit-tests
> 
> 
> File Attachments
> ----------------
> 
> UI/UX
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/27/743aed4b-bee3-4fdc-b48c-283ae78ee400__menu-entry.png
> Frame files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/27/ddd49c4e-43cb-4608-ab08-5080bc628002__formats.png
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131201/533ab976/attachment-0001.html>