[Marble-devel] Review Request 114206: Add menu option (and shortcut) to show/hide all docking panels

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114206/#review44917
-----------------------------------------------------------



src/apps/marble-ui/ControlView.h
<http://git.reviewboard.kde.org/r/114206/#comment32102>

    Doesn't really reflect what is happening, please rename to something like
    togglePanelVisibility()
    



src/apps/marble-ui/ControlView.cpp
<http://git.reviewboard.kde.org/r/114206/#comment32103>

    Should be sentence style capitalization, i.e. "Show or hide all panels". See http://techbase.kde.org/Projects/Usability/HIG/Capitalization



src/apps/marble-ui/ControlView.cpp
<http://git.reviewboard.kde.org/r/114206/#comment32104>

    The indentation looks mixed up. Please indent with four spaces, no tabs. If you are using QtCreator, just select the method and press Ctrl+I.
    


- Dennis Nienhüser


On Nov. 29, 2013, 4:17 p.m., Daniel Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114206/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 4:17 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds a separated menu item on the Settings->Panels menu for showing and also hiding all of the panels at once. The code assigns f9 as the shortcut key. The patch is added to the ControlView module and is shared by the qt and kde versions of marble.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-ui/ControlView.cpp 74a7ba3 
>   src/apps/marble-ui/ControlView.h 8fc3dfb 
> 
> Diff: http://git.reviewboard.kde.org/r/114206/diff/
> 
> 
> Testing
> -------
> 
> Code was tested in both qt and kde versions.
> 
> 
> Thanks,
> 
> Daniel Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131201/d1851998/attachment-0001.html>