[Marble-devel] Review Request 112035: Route synchronization with ownCloud

[Utku Aydın]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112035/
-----------------------------------------------------------

(Updated Aug. 18, 2013, 9:12 p.m.)


Review request for Marble.


Changes
-------

- Added safety checks to route preview code
- Removed cloudsync headers from src/lib/CMakeLists.txt


Description
-------

First review request for "Marble meets ownCloud" Google Summer of Code 2013 project.

Details:
- Marble can upload routes to ownCloud, using the API that Marble's very own 3rd party ownCloud application. -- https://github.com/AndreiDuma/marble-app
- Users can save ownCloud server and credentials information using Marble's (and Marble Qt's) configuration interface.
- This patch also introduces base classes for other synchronization operations (i.e. bookmark sync) which will be implemented in the future.

Known issues:
- For now, adding KMLs to local cache manually and uploading them to cloud via Cloud Routes dialog is not supported.
- Offline mode shows download button after user removes a route from device (cache).
- Route upload progressbar might appear multiple times.

If you want to test but don't want to install ownCloud yourself, contact me for server and account details.


Diffs (updated)
-----

  src/QtMainWindow.cpp 913d0d4 
  src/icons/cloud-download.png PRE-CREATION 
  src/icons/cloud-upload.png PRE-CREATION 
  src/lib/CMakeLists.txt 9b760ee 
  src/lib/MarbleCloudSyncSettingsWidget.ui PRE-CREATION 
  src/lib/MarbleModel.h 973e77c 
  src/lib/MarbleModel.cpp 77e0969 
  src/lib/MarbleWidget.h 6493a6c 
  src/lib/QtMarbleConfigDialog.h 9eb3cfc 
  src/lib/QtMarbleConfigDialog.cpp 47ed016 
  src/lib/cloudsync/AbstractSyncBackend.h PRE-CREATION 
  src/lib/cloudsync/AbstractSyncBackend.cpp PRE-CREATION 
  src/lib/cloudsync/CloudRouteModel.h PRE-CREATION 
  src/lib/cloudsync/CloudRouteModel.cpp PRE-CREATION 
  src/lib/cloudsync/CloudRoutesDialog.h PRE-CREATION 
  src/lib/cloudsync/CloudRoutesDialog.cpp PRE-CREATION 
  src/lib/cloudsync/CloudRoutesDialog.ui PRE-CREATION 
  src/lib/cloudsync/CloudSyncManager.h PRE-CREATION 
  src/lib/cloudsync/CloudSyncManager.cpp PRE-CREATION 
  src/lib/cloudsync/OwncloudSyncBackend.h PRE-CREATION 
  src/lib/cloudsync/OwncloudSyncBackend.cpp PRE-CREATION 
  src/lib/cloudsync/RouteItem.h PRE-CREATION 
  src/lib/cloudsync/RouteItem.cpp PRE-CREATION 
  src/lib/cloudsync/RouteItemDelegate.h PRE-CREATION 
  src/lib/cloudsync/RouteItemDelegate.cpp PRE-CREATION 
  src/lib/cloudsync/RouteParser.h PRE-CREATION 
  src/lib/cloudsync/RouteParser.cpp PRE-CREATION 
  src/lib/cloudsync/RouteSyncManager.h PRE-CREATION 
  src/lib/cloudsync/RouteSyncManager.cpp PRE-CREATION 
  src/lib/routing/RoutingWidget.h 9622ea9 
  src/lib/routing/RoutingWidget.cpp afe1cdd 
  src/marble.kcfg d3b5505 
  src/marble.qrc dc7e8ae 
  src/marble_part.h 1c3dd74 
  src/marble_part.cpp 0a49453 

Diff: http://git.reviewboard.kde.org/r/112035/diff/


Testing
-------

I manually tested every feature on two different servers. There is no unit test available at the moment.


Thanks,

Utku Aydın

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130818/515ee7b5/attachment.html>