[Marble-devel] Review Request 112035: Route synchronization with ownCloud

[Utku Aydın]

> On Aug. 13, 2013, 9:03 p.m., Dennis Nienhüser wrote:
> > src/lib/cloudsync/OwncloudSyncBackend.cpp, line 271
> > <http://git.reviewboard.kde.org/r/112035/diff/1/?file=178321#file178321line271>
> >
> >     Newlines missing. QList also has a removeLast() method.

But m_routeList is a QVector.


> On Aug. 13, 2013, 9:03 p.m., Dennis Nienhüser wrote:
> > src/lib/routing/RoutingWidget.cpp, line 696
> > <http://git.reviewboard.kde.org/r/112035/diff/1/?file=178331#file178331line696>
> >
> >     why a timer here?

I thought timers are only way to access slots directly. Turns out they aren't.


> On Aug. 13, 2013, 9:03 p.m., Dennis Nienhüser wrote:
> > src/lib/cloudsync/RouteItem.h, line 40
> > <http://git.reviewboard.kde.org/r/112035/diff/1/?file=178322#file178322line40>
> >
> >     QString sounds wrong as type. Double probably, mentioning the unit (meter?)

Would it be OK if I fix this when I implement the feature?


> On Aug. 13, 2013, 9:03 p.m., Dennis Nienhüser wrote:
> > src/lib/cloudsync/RouteItem.h, line 43
> > <http://git.reviewboard.kde.org/r/112035/diff/1/?file=178322#file178322line43>
> >
> >     QString sounds wrong as type. Double probably, with a comment mentioning the unit (seconds?)

Same situation with the issue before. Would it be OK if I fix this when I implement the feature?


> On Aug. 13, 2013, 9:03 p.m., Dennis Nienhüser wrote:
> > src/lib/cloudsync/RouteItem.cpp, line 32
> > <http://git.reviewboard.kde.org/r/112035/diff/1/?file=178323#file178323line32>
> >
> >     this shouldn't be commented?
> 
> Dennis Nienhüser wrote:
>     Because of the d-pointer you need to overload the copy ctor and assigment operator, e.g.
>     
>     RouteItem.h:
>     
>         RouteItem(const RouteItem &other);
>         RouteItem& operator=(const RouteItem &other);
>     
>     RouteItem.cpp:
>     
>     RouteItem::RouteItem(const RouteItem &other) :
>       d(new Private(*other.d))
>     {
>       // nothing to do
>     }
>     
>     RouteItem &RouteItem::operator=(const RouteItem &other)
>     {
>       *d = *other.d;
>       return *this;
>     }
>

This will have to wait until I figure out how should I implement this without breaking route preview feature.


- Utku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112035/#review37705
-----------------------------------------------------------


On Aug. 12, 2013, 5:56 p.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112035/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:56 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> First review request for "Marble meets ownCloud" Google Summer of Code 2013 project.
> 
> Details:
> - Marble can upload routes to ownCloud, using the API that Marble's very own 3rd party ownCloud application (https://github.com/AndreiDuma/marble-app).
> - Users can save ownCloud server and credentials information using Marble's (and Marble Qt's) configuration interface.
> - This patch also introduces base classes for other synchronization operations (i.e. bookmark sync) which will be implemented in the future.
> 
> Known issues:
> - For now, adding KMLs to local cache manually and uploading them to cloud via Cloud Routes dialog is not supported.
> - Offline mode shows download button after user removes a route from device (cache).
> - Route upload progressbar might appear multiple times.
> 
> If you want to test but don't want to install ownCloud yourself, contact me for server and account details.
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.cpp 913d0d4 
>   src/icons/cloud-download.png PRE-CREATION 
>   src/icons/cloud-upload.png PRE-CREATION 
>   src/lib/CMakeLists.txt 88c188a 
>   src/lib/MarbleCloudSyncSettingsWidget.ui PRE-CREATION 
>   src/lib/MarbleModel.h 973e77c 
>   src/lib/MarbleModel.cpp 77e0969 
>   src/lib/MarbleWidget.h 6493a6c 
>   src/lib/QtMarbleConfigDialog.h 9eb3cfc 
>   src/lib/QtMarbleConfigDialog.cpp 47ed016 
>   src/lib/cloudsync/AbstractSyncBackend.h PRE-CREATION 
>   src/lib/cloudsync/AbstractSyncBackend.cpp PRE-CREATION 
>   src/lib/cloudsync/CloudRouteModel.h PRE-CREATION 
>   src/lib/cloudsync/CloudRouteModel.cpp PRE-CREATION 
>   src/lib/cloudsync/CloudRoutesDialog.h PRE-CREATION 
>   src/lib/cloudsync/CloudRoutesDialog.cpp PRE-CREATION 
>   src/lib/cloudsync/CloudRoutesDialog.ui PRE-CREATION 
>   src/lib/cloudsync/CloudSyncManager.h PRE-CREATION 
>   src/lib/cloudsync/CloudSyncManager.cpp PRE-CREATION 
>   src/lib/cloudsync/OwncloudSyncBackend.h PRE-CREATION 
>   src/lib/cloudsync/OwncloudSyncBackend.cpp PRE-CREATION 
>   src/lib/cloudsync/RouteItem.h PRE-CREATION 
>   src/lib/cloudsync/RouteItem.cpp PRE-CREATION 
>   src/lib/cloudsync/RouteItemDelegate.h PRE-CREATION 
>   src/lib/cloudsync/RouteItemDelegate.cpp PRE-CREATION 
>   src/lib/cloudsync/RouteParser.h PRE-CREATION 
>   src/lib/cloudsync/RouteParser.cpp PRE-CREATION 
>   src/lib/cloudsync/RouteSyncManager.h PRE-CREATION 
>   src/lib/cloudsync/RouteSyncManager.cpp PRE-CREATION 
>   src/lib/routing/RoutingWidget.h 9622ea9 
>   src/lib/routing/RoutingWidget.cpp afe1cdd 
>   src/marble.kcfg d3b5505 
>   src/marble.qrc dc7e8ae 
>   src/marble_part.h 1c3dd74 
>   src/marble_part.cpp 6cbb319 
> 
> Diff: http://git.reviewboard.kde.org/r/112035/diff/
> 
> 
> Testing
> -------
> 
> I manually tested every feature on two different servers. There is no unit test available at the moment.
> 
> 
> Thanks,
> 
> Utku Aydın
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130816/3d3becae/attachment-0001.html>