[Marble-devel] Review Request 111932: GroundOverlay Rendering example

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111932/#review37301
-----------------------------------------------------------

Ship it!


Looks good, but please be verbose wrt comments, it's a tutorial.


examples/cpp/overlay-rendering/main.cpp
<http://git.reviewboard.kde.org/r/111932/#comment27599>

    BlueMarble => Satellite



examples/cpp/overlay-rendering/main.cpp
<http://git.reviewboard.kde.org/r/111932/#comment27603>

    Move down a bit, please



examples/cpp/overlay-rendering/main.cpp
<http://git.reviewboard.kde.org/r/111932/#comment27600>

    // Create a bounding box from the given corner points



examples/cpp/overlay-rendering/main.cpp
<http://git.reviewboard.kde.org/r/111932/#comment27601>

    // Create an overlay and assign the image to render and its bounding box to it



examples/cpp/overlay-rendering/main.cpp
<http://git.reviewboard.kde.org/r/111932/#comment27602>

    // Create a document as a container for the overlay


- Dennis Nienhüser


On Aug. 7, 2013, 11:23 a.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111932/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2013, 11:23 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> Adds an example program showing how to display an image on the globe surface.
> 
> 
> Diffs
> -----
> 
>   examples/cpp/overlay-rendering/CMakeLists.txt e69de29 
>   examples/cpp/overlay-rendering/main.cpp e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/111932/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130807/3697d1c7/attachment-0001.html>