[Marble-devel] Review Request 111839: Adds a TileID::toLatLonBox() function returning a tileId's corresponding bounding box

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111839/#review36966
-----------------------------------------------------------


Nice work. I've tested your changes with this map theme [1] and needed to fix a few things mentioned below.

[1] https://gitorious.org/marble-restricted-maps/brandenburg


src/lib/ServerLayout.cpp
<http://git.reviewboard.kde.org/r/111839/#comment27268>

    Please pass GeoDataCoordinates::Degree as parameter to west() because we need the coordinate in degrees.



src/lib/ServerLayout.cpp
<http://git.reviewboard.kde.org/r/111839/#comment27269>

    dito



src/lib/ServerLayout.cpp
<http://git.reviewboard.kde.org/r/111839/#comment27270>

    dito



src/lib/ServerLayout.cpp
<http://git.reviewboard.kde.org/r/111839/#comment27271>

    dito



src/lib/TileId.h
<http://git.reviewboard.kde.org/r/111839/#comment27267>

    Please remove the unit parameter. It is not needed because internally GeoDataLatLonBox stores the coordinates in radians.


- Bernhard Beschow


On Aug. 1, 2013, 4:02 p.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111839/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 4:02 p.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> Adds a TileID::toLatLonBox() function and makes use of it in ServerLayout.
> 
> 
> Diffs
> -----
> 
>   src/tilecreator/CMakeLists.txt f1eed44 
>   src/lib/TileId.cpp a1a0af9 
>   src/lib/TileId.h 383de68 
>   src/lib/ServerLayout.h b4752f4 
>   src/lib/ServerLayout.cpp 69dfbf6 
> 
> Diff: http://git.reviewboard.kde.org/r/111839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130802/b62b8012/attachment.html>