[Marble-devel] Review Request 111838: Change GeoDataIconStyle to use QPixmap instead of QImage internally

[René Küttner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111838/
-----------------------------------------------------------

(Updated Aug. 1, 2013, 4:25 p.m.)


Review request for Marble.


Changes
-------

The description and the patch did not match by accident. This is now fixed (thanks to shentey for pointing it out).


Summary (updated)
-----------------

Change GeoDataIconStyle to use QPixmap instead of QImage internally


Description (updated)
-------

GeoDataIconStyle stores its icon as a QImage at the moment. Since these styles are meant for rendering and QImage is rather slow for this purpose, I changed it to use QPixmap internally.


Diffs
-----

  src/lib/MarbleWidgetPopupMenu.cpp ba27f36 
  src/lib/VisiblePlacemark.cpp 42c1103 
  src/lib/geodata/data/GeoDataFeature.h 4cd0374 
  src/lib/geodata/data/GeoDataFeature.cpp 8a99a85 
  src/lib/geodata/data/GeoDataIconStyle.h 5b4644f 
  src/lib/geodata/data/GeoDataIconStyle.cpp d68d0bb 

Diff: http://git.reviewboard.kde.org/r/111838/diff/


Testing (updated)
-------

I applied the patch to master and did compile marble. I also compared the visual output of the icon style before and after the patch.


Thanks,

René Küttner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130801/5ab2d841/attachment-0001.html>