[Marble-devel] Review Request 109379: ElevationProfile: support for gpx-tracks

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109379/#review31635
-----------------------------------------------------------



src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h
<http://git.reviewboard.kde.org/r/109379/#comment23547>

    Please const'ify MarbleModel and the pointer, i.e. "const MarbleModel *const m_marbleModel".



src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h
<http://git.reviewboard.kde.org/r/109379/#comment23548>

    Please also const'ify this pointer since it isn't changed again.



src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp
<http://git.reviewboard.kde.org/r/109379/#comment23545>

    Please remove the const_cast and pass a const MarbleModel * here. I've pushed 4e159ac1b4e8d0137813389eabcdac4c71e01a2b to make this work.



src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp
<http://git.reviewboard.kde.org/r/109379/#comment23546>

    dito


- Bernhard Beschow


On April 16, 2013, 5:19 p.m., Roman Karlstetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109379/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 5:19 p.m.)
> 
> 
> Review request for Marble and Bernhard Beschow.
> 
> 
> Description
> -------
> 
> Changes to the elevation profile plugin, it's now possible to display the height profile for a GPX-track opened from file.
> 
> I made a new classes for
> a) providing the data, one for routes and one for tracks. They are in the same file, should this be split into multiple files?
> b) the contextmenu, because it has some members which would only clutter ElevationProfileFloatItem. It is a friend class, is this ok?
> 
> Comments please :) 
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/CMakeLists.txt 872e5e1 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.cpp PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.cpp PRE-CREATION 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h cb3bff1 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp 7cb3428 
> 
> Diff: http://git.reviewboard.kde.org/r/109379/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Karlstetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130426/0ab48fd9/attachment.html>