[Marble-devel] Review Request 109990: Fixed select by Enter in MapViewWidget

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109990/#review31113
-----------------------------------------------------------



src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/109990/#comment23123>

    This seems like the wrong place. Please move to line 362.



src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/109990/#comment23124>

    Please connect to the mapThemeSelected() slot directly because emitting activated() might cause confusion. Moreover, there should be a comment as to why the slot gets connected twice.



src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/109990/#comment23125>

    For systems where single-clicking is active, I could imagine that this slot gets called twice. This should ideally be avoided or at least the emit statement should fire only if the map theme is actually changed.


- Bernhard Beschow


On April 15, 2013, 5:41 p.m., Andrei Duma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109990/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 5:41 p.m.)
> 
> 
> Review request for Marble and Bernhard Beschow.
> 
> 
> Description
> -------
> 
> Selecting by pressing Enter works now in MapViewWidget.
> 
> Selecting by right-clicking doesn't work anymore. However, right-clicking should only offer a menu for selecting options; it doesn't serve the same purpose as left-click.
> 
> 
> This addresses bug 318280.
>     http://bugs.kde.org/show_bug.cgi?id=318280
> 
> 
> Diffs
> -----
> 
>   src/lib/MapViewWidget.cpp a8b351b 
> 
> Diff: http://git.reviewboard.kde.org/r/109990/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Duma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130415/95a2c8d1/attachment.html>