[Marble-devel] Review Request 109990: Fixed select by Enter in MapViewWidget

Dennis Nienhüser earthwings at gentoo.org
Sat Apr 13 11:39:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109990/
-----------------------------------------------------------

(Updated April 13, 2013, 11:39 a.m.)


Review request for Marble and Bernhard Beschow.


Changes
-------

Looks good to me.

@Bernhard: From the git log I think you introduced pressed() in 21311d2. Is there a reason to favor that one instead of activated(), maybe on mobile (Maemo)?


Description
-------

Selecting by pressing Enter works now in MapViewWidget.

Selecting by right-clicking doesn't work anymore. However, right-clicking should only offer a menu for selecting options; it doesn't serve the same purpose as left-click.


This addresses bug 318280.
    http://bugs.kde.org/show_bug.cgi?id=318280


Diffs
-----

  src/lib/MapViewWidget.cpp a8b351b 

Diff: http://git.reviewboard.kde.org/r/109990/diff/


Testing
-------


Thanks,

Andrei Duma

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130413/0aa90675/attachment.html>


More information about the Marble-devel mailing list