[Marble-devel] Review Request 109921:

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109921/#review30822
-----------------------------------------------------------


Looks good and works fine (see comments below though).


src/lib/MapInfoDialog.h
<http://git.reviewboard.kde.org/r/109921/#comment22938>

    Add a note please like
    
    This has the same effect as setVisible( true ) and additionally adjusts the viewport such that the dialog is fully visible.



src/lib/MapInfoDialog.h
<http://git.reviewboard.kde.org/r/109921/#comment22937>

    I'd avoid the redundancy here and just use m_popupItem->coordinate() to retrieve the coordinates where needed.
    



src/lib/MapInfoDialog.cpp
<http://git.reviewboard.kde.org/r/109921/#comment22936>

    m_widget must be initialized to 0 here.


- Dennis Nienhüser


On April 9, 2013, 8:16 a.m., Andrei Duma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109921/
> -----------------------------------------------------------
> 
> (Updated April 9, 2013, 8:16 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> The map recenters itself now. No bonus shifting yet.
> 
> Note: uses qDebug; will remove.
> 
> 
> This addresses bug 318057.
>     http://bugs.kde.org/show_bug.cgi?id=318057
> 
> 
> Diffs
> -----
> 
>   src/lib/MapInfoDialog.h 1510b97 
>   src/lib/MapInfoDialog.cpp fa7b0d6 
>   src/lib/MarbleWidget.cpp f9b46a7 
>   src/lib/MarbleWidgetPopupMenu.cpp 35d240f 
> 
> Diff: http://git.reviewboard.kde.org/r/109921/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Duma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130409/a043c028/attachment-0001.html>