[Marble-devel] Review Request 109908: MapInfoPopup adaptable size.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109908/#review30657
-----------------------------------------------------------


Looks good. One problem arises when resizing the window to a very small size:
QWidget::setMinimumSize: (/QWidget) Negative sizes (-118,-1) are not possible
I think we also need an (internal) minimum size for the dialog.


- Dennis Nienhüser


On April 8, 2013, 9:14 a.m., Andrei Duma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109908/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 9:14 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Adaptable popup size (based on requested size and maximum size imposed by viewport dimensions).
> 
> 
> This addresses bug 317839.
>     http://bugs.kde.org/show_bug.cgi?id=317839
> 
> 
> Diffs
> -----
> 
>   src/lib/MapInfoDialog.h 79f76c3 
>   src/lib/MapInfoDialog.cpp b0c26dd 
> 
> Diff: http://git.reviewboard.kde.org/r/109908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Duma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130408/1627883a/attachment-0001.html>