[Marble-devel] Review Request 105456: Task #10 from Trello

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105456/#review30629
-----------------------------------------------------------



src/lib/Projections/SphericalProjection.cpp
<http://git.reviewboard.kde.org/r/105456/#comment22780>

    remove



src/lib/ViewportParams.cpp
<http://git.reviewboard.kde.org/r/105456/#comment22781>

    explain in a comment, please



src/lib/ViewportParams.cpp
<http://git.reviewboard.kde.org/r/105456/#comment22779>

    This is hard to read. I'd shorten the following lines to
    
    qreal const firstOp = d->m_constantDetailFactor * angularResolution();
    d->m_detailLevel = qCeil( qLn( firstOp ) / d->m_constantLnOneOverTwo );
    
    Maybe even qFloor(...)+1 if that is really the intention.
    


- Dennis Nienhüser


On July 6, 2012, 8:38 a.m., Cezar Mocan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105456/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 8:38 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> Task #10 from Trello, using the angular resolution in order to compute the detail level. 
> 
> 
> Diffs
> -----
> 
>   src/lib/Projections/SphericalProjection.cpp 2840e1d 
>   src/lib/ViewportParams.h 41d29cf 
>   src/lib/ViewportParams.cpp c83d884 
>   src/lib/geodata/data/GeoDataLineString.cpp 43b1b35 
> 
> Diff: http://git.reviewboard.kde.org/r/105456/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cezar Mocan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130407/53bb9d65/attachment.html>