[Marble-devel] Review Request 109377: Try to parse GPX-Files when they have no namespace declaration

Dennis Nienhüser earthwings at gentoo.org
Sat Apr 6 14:37:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109377/
-----------------------------------------------------------

(Updated April 6, 2013, 2:37 p.m.)


Review request for Marble and Dennis Nienhüser.


Changes
-------

Add marble group as reviewer


Description
-------

Currently, when you try to load a track from a GPX-file with a missing namespace declaration, just nothing happens (file is not loaded and there is nothing indicating to the user that loading has failed). With this small patch, marble tries to parse a GPX file without a namespace declaration and prints a debug message.

Should there be a notification for the user when parsing (not just for GPX) fails? 


This addresses bug 314482.
    http://bugs.kde.org/show_bug.cgi?id=314482


Diffs
-----

  src/plugins/runner/gpx/GpxParser.cpp d1a32c2 

Diff: http://git.reviewboard.kde.org/r/109377/diff/


Testing
-------


Thanks,

Roman Karlstetter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130406/807b6ca1/attachment.html>


More information about the Marble-devel mailing list