[Marble-devel] Review Request 109866: JJ: Download Progress Bar for Marble Qt

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109866/#review30452
-----------------------------------------------------------

Ship it!


Looks good, please commit.


src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/109866/#comment22708>

    imho the TODO comment can be removed. I guess that >99% of the KDE users are not aware that there is a context menu on the status bar for such kind of configurations...
    



src/QtMainWindow.cpp
<http://git.reviewboard.kde.org/r/109866/#comment22709>

    imho the TODO comment can be removed. I guess that >99% of the KDE users are not aware that there is a context menu on the status bar for such kind of configurations...
    


- Dennis Nienhüser


On April 5, 2013, 9:15 a.m., Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109866/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 9:15 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This is a patch that implements the junior job as described in bug 310051: Showing a progress bar in Marble-Qt as Marble-KDE already does. Most of the code is copied from the KDE variant, with minor adjustments to Qt.
> 
> 
> This addresses bug 310051.
>     http://bugs.kde.org/show_bug.cgi?id=310051
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.h 56266d0 
>   src/QtMainWindow.cpp 32bb80e 
> 
> Diff: http://git.reviewboard.kde.org/r/109866/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130405/dddd5b84/attachment.html>