[Marble-devel] Review Request: StarsPlugin: show the Sun

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106375/#review18911
-----------------------------------------------------------

Ship it!


Nice, it might be useful to use a more general class in the future instead of SunLocator in order to calculate positions for the Moon and planets.

- Torsten Rahn


On Sept. 7, 2012, 7:46 p.m., René Küttner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106375/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2012, 7:46 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This adds the Sun to the Stars plugin (see screenshot).
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt d612723 
>   data/svg/sun.png PRE-CREATION 
>   src/plugins/render/stars/StarsPlugin.h 6aeebf5 
>   src/plugins/render/stars/StarsPlugin.cpp f8a7688 
> 
> Diff: http://git.reviewboard.kde.org/r/106375/diff/
> 
> 
> Testing
> -------
> 
> Tested with QT-only and KDE build.
> 
> 
> Screenshots
> -----------
> 
> Screenshot
>   http://git.reviewboard.kde.org/r/106375/s/721/
> 
> 
> Thanks,
> 
> René Küttner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120912/7c658ecb/attachment.html>