[Marble-devel] Review Request: Foursquare authentication

[Utku Aydın]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107011/
-----------------------------------------------------------

(Updated Oct. 30, 2012, 8:11 p.m.)


Review request for Marble.


Changes
-------

Made changes that Dennis mentioned.


Description
-------

With this patch, Foursquare plugin users now can allow Marble to make requests to Foursquare on behalf of them. Currently works only on Marble Touch, and has minor problems, e.g. the login page is not scrollable.

The patch also fixes the problem with the venue details sidebar, widens the sidebar if the detail texts are longer than it. It also adds the missing declarativeModel method to DeclarativeDataPlugin class.


Diffs (updated)
-----

  src/plugins/declarative/DeclarativeDataPlugin.cpp 73406b8 
  src/plugins/render/foursquare/FoursquarePlugin.h fc75f06 
  src/plugins/render/foursquare/FoursquarePlugin.cpp ae8210c 
  src/qt-components/marble-touch/activities/Explore.qml 85d4344 

Diff: http://git.reviewboard.kde.org/r/107011/diff/


Testing
-------

Printed the API key using qDebug(), got a string that looks like an API key.


Thanks,

Utku Aydın

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121030/04965092/attachment.html>