[Marble-devel] Review Request: Foursquare authentication

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107011/#review21155
-----------------------------------------------------------


Looks good, but I haven't tested it yet.


src/plugins/render/foursquare/FoursquarePlugin.h
<http://git.reviewboard.kde.org/r/107011/#comment16558>

    const QString &tokenUrl for consistency (you might have to create a new QString then in the method body where remove() is called)



src/plugins/render/foursquare/FoursquarePlugin.cpp
<http://git.reviewboard.kde.org/r/107011/#comment16559>

    could be simplified to
    
    return !settings.value( "access_token" ).isNull();
    



src/qt-components/marble-touch/activities/Explore.qml
<http://git.reviewboard.kde.org/r/107011/#comment16560>

    shouldn't be needed with the change below



src/qt-components/marble-touch/activities/Explore.qml
<http://git.reviewboard.kde.org/r/107011/#comment16561>

    visible: authButton.checked
    



src/qt-components/marble-touch/activities/Explore.qml
<http://git.reviewboard.kde.org/r/107011/#comment16562>

    What does stop refer to?


- Dennis Nienhüser


On Oct. 23, 2012, 4:02 p.m., Utku Aydın wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107011/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 4:02 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> With this patch, Foursquare plugin users now can allow Marble to make requests to Foursquare on behalf of them. Currently works only on Marble Touch, and has minor problems, e.g. the login page is not scrollable.
> 
> The patch also fixes the problem with the venue details sidebar, widens the sidebar if the detail texts are longer than it. It also adds the missing declarativeModel method to DeclarativeDataPlugin class.
> 
> 
> Diffs
> -----
> 
>   src/plugins/declarative/DeclarativeDataPlugin.cpp 73406b8 
>   src/plugins/render/foursquare/FoursquarePlugin.h fc75f06 
>   src/plugins/render/foursquare/FoursquarePlugin.cpp ae8210c 
>   src/qt-components/marble-touch/activities/Explore.qml 85d4344 
> 
> Diff: http://git.reviewboard.kde.org/r/107011/diff/
> 
> 
> Testing
> -------
> 
> Printed the API key using qDebug(), got a string that looks like an API key.
> 
> 
> Thanks,
> 
> Utku Aydın
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121030/7460e39b/attachment.html>