[Marble-devel] Review Request: Avoid some QAction-related warnings in the KDE version

[Torsten Rahn]

> On Oct. 26, 2012, noon, Torsten Rahn wrote:
> > So this patch basically copies the existing code into three different places and just for the sake of KAction (which will hopefully go the way of the Dodo for KDE 5 ...) ? I fail to see the advantage.
> 
> Bernhard Beschow wrote:
>     I agree with the fact that copying the code into three different places is not optimal. Still, there is the advantage of not spamming the user's console windows with technical warnings that they're not responsible for, and which might even be irritating ("Do these actions work?"). Moreover, this patch was burried locally on my computer, so I wanted to see if there is a chance to have it in master before the coding style change.
>     
>     That said, I don't agree with your tone. At least I'm missing some words in your comment which respect my work. Remember that I participate in Marble on a voluntary basis, which should be fun and encuraging. However, if I keep getting complaints rather than constructive feedback for my efforts, I might have to rethink my involvement in Marble. In my opinion, this would be a real pity for both of us since I like to work on Marble, and you - as its founder - probably want to see it prosper, too.
>     
>     Perhaps my response seems a bit disproportionate. This might be due to the fact that I see no serious interest in fixing IMO important bugs like (a) stalls during panning, (b) proper .gpx support, (c) energy consumption on mobile devices and (d) polishing the user interface towards defined use cases. While I've been working on all four issues, I already got discuraging feedback once I tried to fix (a). So it makes me wonder whether my dedication is worth the effort.

Hello Bernhard,
I'm sorry if my comment looked like a complaint. And I'm surprised to hear that you feel a lack of appreciation for the truely awesome work that you've done for Marble. There are lots of reasons for praising the work that you have done so far for Marble. And I've done that in the past numerous times. You are one of the essential guys who keep Marble ticking and therefore you call the shots - which is great since many of your thoughts are well-reasoned. But we are both striving for excellence and therefore my comments are not meant to question your work - rather the opposite. Sometimes I also just fail to see the problem (like in this case) and therefore ask for explanations. Isn't this the job this reviewboard, doing critical reflexions?   

I'm sorry if my comment looked like a complaint. It wasn't meant to be one. I was just seriously asking whether this move would be a good one given the fact that KAction might be removed altogether. Personally I'm not against this patch, so feel free to ship it.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106988/#review20950
-----------------------------------------------------------


On Oct. 22, 2012, 4:24 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106988/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2012, 4:24 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> API change: remove RenderPlugin::action()
> 
> With this patch, the actions are created outside of the plugins which is more flexible.
> In the KDE version, for instance, creation of KActions (rather than QActions) avoids 'marble(26988)/kdeui (kdelibs): Attempt to use QAction "" with KXMLGUIFactory!' warnings.
> 
> 
> Diffs
> -----
> 
>   src/QtMainWindow.h 707855f33b12a4508853dd76c8a18bc2bb06cdf6 
>   src/QtMainWindow.cpp 171190097748cadffd2c7aba268fa0ec5f5a8067 
>   src/lib/MarbleWidgetPopupMenu.cpp 4da64b0c84cbe66b59b51f59f3641c5f7879cb05 
>   src/lib/RenderPlugin.h 63df0432bfc3ae4de851cabe92d839bf93c50662 
>   src/lib/RenderPlugin.cpp 373205de5a4e1cd6016ffaf181bf55a1ecf368ba 
>   src/marble_part.h 098d63793904761f997223eff166a6ccd2568389 
>   src/marble_part.cpp 85269d80f1d164fa12a6b6f13f2e3b8ab0172ca1 
> 
> Diff: http://git.reviewboard.kde.org/r/106988/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121029/534544da/attachment.html>