[Marble-devel] Review Request: add application/x-gpx+xml, application/x-osm+xml, application/x-esri-shape to the mime-type database

[Friedrich W. H. Kossebau]

> On Oct. 22, 2012, 5:38 p.m., Thibaut Gridel wrote:
> > A bit early commit... please allow us to comment :)
> > 
> > Couldn't the behaviour be the same for every plugin?
> > I mean that gpx, osm and shp are all runner plugins, so if eg someone disables gpx the install shouldn't setup gpx mime info.
> > 
> > Otherwise thanks for fixing this!

Right, seems I was too eager to get this stuff in as fast as possible, should have waited a few more days and not just for the first "Ship it" to appear.

The reason I only used that separate-desktop-files approach for shapefiles was that to me it looked that gpx and osm are always built and installed, at least I saw nothing in the src/plugins/runner/../CMakeLists.txt which hinted that gpx and osm are optional, perhaps I missed something?

Then of course it would be perhaps less complex if there was not an exception in the treatment of the shp plugin, but instead all import(?) plugins are treated the same way. Hm. Your call :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106977/#review20686
-----------------------------------------------------------


On Oct. 22, 2012, 10:33 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106977/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2012, 10:33 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> This patch installs an extension of the mimetype database for the three file types.
> 
> This way such files get a nicer display in the file dialogs/managers and can also finally be bound to the Marble program by the mimetype ids.
> 
> To have Marble noted as handler for application/x-esri-shape only if the related plugin is installed, I followed the advise of Albert, see http://lists.kde.org/?l=kde-devel&m=135083816331959&w=2
> 
> Still to do after this patch:
> * have the view zoom to the loaded shape/track
> 
> Patch additionally installs a mimetype for the Esri shapefile index, so this file at least looks better in the filemanager.
> That mimetype is made up by me. Not sure if this is useful, could also remove this from the patch if you prefer. For that reason I have also not yet added entries for the two other additional file types with shapefiles.
> 
> PS: After applying the patch and installing somehow the new info about the mimetypes and that marble supports them seems to not make it to all running programs. For me it worked only completely after a restart of the workspace session, so please try that before reporting problems.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7f8777e 
>   data/CMakeLists.txt 316d005 
>   data/mimetypes/XmlMessages.sh PRE-CREATION 
>   data/mimetypes/geo.xml PRE-CREATION 
>   src/marble.desktop 3b61616 
>   src/marble_part.desktop 9a75d07 
>   src/plugins/runner/shp/CMakeLists.txt 0ef8c65 
>   src/plugins/runner/shp/marble_part_shp.desktop PRE-CREATION 
>   src/plugins/runner/shp/marble_shp.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106977/diff/
> 
> 
> Testing
> -------
> 
> Clicking an gpx file or a shape file starts Marble and loads the file.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121022/8bcd46f5/attachment.html>