[Marble-devel] Review Request: Fancy Colors added to MarbleGlobal.h (MarbleColors.h)

[Illya Kovalevskyy]

> On Nov. 30, 2012, 5:39 p.m., Torsten Rahn wrote:
> > src/lib/MarbleGlobal.h, line 222
> > <http://git.reviewboard.kde.org/r/107535/diff/1/?file=96960#file96960line222>
> >
> >     I guess you also need to remove those.

>> I guess you need to remove the now duplicated colors inside MarbleGlobal.h

I thought that they must be left for reverse-support. Is Marble code use them?


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107535/#review22827
-----------------------------------------------------------


On Nov. 30, 2012, 5:19 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107535/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 5:19 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> In frame of Google Code-In Task (http://www.google-melange.com/gci/task/view/google/gci2012/7954223) I have added MarbleColors.h file.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleColors.h PRE-CREATION 
>   src/lib/MarbleGlobal.h 8938faa 
> 
> Diff: http://git.reviewboard.kde.org/r/107535/diff/
> 
> 
> Testing
> -------
> 
> I have built and run it on Ubuntu 12.10 on Intel
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121130/e4bca44e/attachment-0001.html>