[Marble-devel] Review Request: KML random <colorMode> functionality

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107478/#review22618
-----------------------------------------------------------


Great work and welcome to the "real" Marble development :-)


src/lib/geodata/data/GeoDataColorStyle.h
<http://git.reviewboard.kde.org/r/107478/#comment17303>

    "paintColor()" sounds like a method that would do the actual painting. So maybe this should be called
    
    paintedColor()
    
    instead.



src/lib/geodata/data/GeoDataColorStyle.cpp
<http://git.reviewboard.kde.org/r/107478/#comment17302>

    This looks overly complex to me. Why not just do the whole method in three lines of code:
    
            d->m_randomColor.setRedF(color().redF()*(qrand()/(qreal)RAND_MAX));
            d->m_randomColor.setGreenF(color().greenF()*(qrand()/(qreal)RAND_MAX));
            d->m_randomColor.setBlueF(color().blueF()*(qrand()/(qreal)RAND_MAX));
    


- Torsten Rahn


On Nov. 26, 2012, 6:12 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107478/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 6:12 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> added the KML random <colorMode> functionality according to the KML specifications 
> 
> 
> Diffs
> -----
> 
>   src/lib/geodata/data/GeoDataColorStyle.h aa40073 
>   src/lib/geodata/data/GeoDataColorStyle.cpp 723f7e2 
>   src/lib/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 0b89be5 
>   src/lib/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp 1050a3e 
> 
> Diff: http://git.reviewboard.kde.org/r/107478/diff/
> 
> 
> Testing
> -------
> 
> yes, testing done
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121127/0042560a/attachment-0001.html>